DM-48481: Add config overrides to maintain compatibility with current LATISS and ComCam calibs #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Jan 21, 2025
| # Maintain compatibility with existing calibrations. | ||
| # TODO: Remove these for running new calibs with DM-48520. | ||
| poscan = config.overscanCamera.defaultDetectorConfig.defaultAmpConfig.parallelOverscanConfig | ||
| poscan.doAbsoluteMaxDeviation = True |
There was a problem hiding this comment.
Is this True to protect against this parameter being changed to False? As is, this has no effect because doAbsoluteMaxDeviation=True by default.
There was a problem hiding this comment.
This is intentional, and is an override because the default is False in the parallel overscan task referenced here (but is True for the other overscan tasks).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.