DM-23033: Clarify reference catalog creation docs. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim here is to make it clearer that we're really just running a task, which could be executed from the command line, before worrying about globs and parallelism and all that fun stuff.
parejkoj
approved these changes
Jan 13, 2020
| .. prompt:: bash | ||
|
|
||
| mkdir /path/to/my_repo | ||
| echo "lsst.obs.test.TestMapper" > /path/to/my_repo/_mapper |
There was a problem hiding this comment.
I'm not hugely happy about this, since this method of making a pseudo-butler is going away in gen3, but then again the code I wrote isn't gen3 compatible, so I guess its fine?
There was a problem hiding this comment.
I am a Gen 3 neophyte. Is there a better way to do this? I didn't know of one, but if there is I'll happily use that instead.
There was a problem hiding this comment.
For gen3 there is not; you call Butler.makeRepo(), but the refcat ingester is only gen2 right now anyway...
I do wonder whether this bit about making a fake repo should just be removed, as anyone running this is going to have a butler repo available.
|
Yes: I confirmed it looks ok locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim here is to make it clearer that we're really just running a task,
which could be executed from the command line, before worrying about globs and
parallelism and all that fun stuff.