Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47385: Refine mask exclusion behavior in removeBadPixels (aka cancel original masks) #357

Merged
merged 1 commit into from
Nov 9, 2024
Merged

DM-47385: Refine mask exclusion behavior in removeBadPixels (aka cancel original masks) #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/test_dipoleFitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,13 @@ def testDipoleEdge(self):
not detected.
"""

# with no edge we should detect both dipole sources
# with no edge, and masks growing due to convolution,
# we should not detect any dipole sources
# (If we were to keep the original mask instead, as in DM-45318 that
# was subsequently canceled in DM-47385, we will detect 2 sources)
dipoleTestImage = DipoleTestImage(xc=[5.3, 4.8], yc=[4.6, 86.5], flux=[200, 210], edgeWidth=0)
sources = self._runDetection(dipoleTestImage)
self.assertEqual(len(sources), 2)
self.assertEqual(len(sources), 0)

# with a wide edge we should not detect any sources
dipoleTestImage = DipoleTestImage(xc=[5.3, 4.8], yc=[4.6, 86.5], flux=[200, 210], edgeWidth=20)
Expand Down
Loading