Add Spectrum objects for obs_fiberSpectrograph

[aferte]

We are only doing the merge for daf_butler now and will do the obs package later.

[timj]

I don't like the name of this. Spectrum sounds like a generic class whereas this is specifically a spectrum from the fiber spectrograph, which doesn't sound like it's a Spectrum that a different spectrograph would use. Maybe it is, but then it's probably in the wrong place. Can you please give me some guidance? Otherwise FiberSpectrum would be better.

[aferte]

I see - indeed I believe we only expect this from the fiber spectrograph. Would it be ok to replace it by fiberSpectroData?

[aferte]

Or rather fiberSpecData as FiberSpec is the name of the instrument in the obs package.

[timj]

Convention is for upper case first letter.

"Data from the fiber spectrograph" seems like it might mean the raw. That's why I was edging towards FiberSpectrum as in spectrum from fiber. FiberSpecSpectrum might work if you don't mind doubling up "Spec".

[aferte]

Sounds good - done in daf_butler and I will update the obs package accordingly later on this week.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfad270) 87.31% compared to head (9bdaa3b) 87.31%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files         286      286           
  Lines       37168    37168           
  Branches     7833     7833           
=======================================
  Hits        32452    32452           
  Misses       3519     3519           
  Partials     1197     1197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.