Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48452: Protect subcommand imports via entry points #1141

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

timj
Copy link
Member

@timj timj commented Jan 15, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

timj added 3 commits January 15, 2025 11:06
Previously errors loading a subcommand broke everything (unlike
the old way of loading subcommands).
It stopped being available.
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (c03a7ff) to head (7ee97ef).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/daf/butler/cli/butler.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
- Coverage   89.50%   89.49%   -0.01%     
==========================================
  Files         366      366              
  Lines       49015    49020       +5     
  Branches     5941     5941              
==========================================
  Hits        43872    43872              
- Misses       3728     3733       +5     
  Partials     1415     1415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj merged commit 36545c9 into main Jan 15, 2025
17 of 19 checks passed
@timj timj deleted the tickets/DM-48452 branch January 15, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants