DM-46936: Fix cache exception when unexpected files present #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where DatastoreCacheManager would raise ValueError('badly formed hexadecimal UUID string') if files with unexpected names are present in the cache directory when trying to load a file from the cache.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
=======================================
Coverage 89.49% 89.50%
=======================================
Files 366 366
Lines 48832 48848 +16
Branches 5906 5907 +1
=======================================
+ Hits 43703 43720 +17
+ Misses 3720 3719 -1
Partials 1409 1409 ☔ View full report in Codecov by Sentry. |
|
Failing Docker build is unrelated and will be fixed later this week. |
andy-slac
approved these changes
Dec 16, 2024
Comment on lines
+1207
to
+1210
| class InvalidCacheFilenameError(Exception): | ||
| """Raised when attempting to register a file in the cache with a name in | ||
| the incorrect format. | ||
| """ |
There was a problem hiding this comment.
Maybe move it to the top, took me a minute to figure out where the name came from when I read the code above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where DatastoreCacheManager would raise ValueError('badly formed hexadecimal UUID string') if files with unexpected names are present in the cache directory when trying to load a file from the cache.
Checklist
doc/changesconfigs/old_dimensions