Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47947: fix consistency bug in aggregate spatial overlap postprocessing #1131

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Dec 10, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

@TallJimbo TallJimbo force-pushed the tickets/DM-47947 branch 2 times, most recently from cc72008 to d6af6a3 Compare December 10, 2024 19:26
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (8636101) to head (7c75861).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...t/daf/butler/direct_query_driver/_query_builder.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
- Coverage   89.49%   89.49%   -0.01%     
==========================================
  Files         366      366              
  Lines       48805    48832      +27     
  Branches     5900     5906       +6     
==========================================
+ Hits        43680    43703      +23     
- Misses       3718     3720       +2     
- Partials     1407     1409       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

andy-slac and others added 4 commits December 13, 2024 14:48
The class this method's old name referred to was renamed to
SqlJoinsBuilder in an earlier commit.
Instead of testing (a UNION b) OVERLAPS (c UNION d) in these queries,
we now correctly test (a OVERLAPS c) OR (b OVERLAPS d).
@TallJimbo TallJimbo force-pushed the tickets/DM-47947 branch 2 times, most recently from ed8fcda to 7c75861 Compare December 13, 2024 19:53
@TallJimbo TallJimbo merged commit 812ef82 into main Dec 13, 2024
18 of 19 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-47947 branch December 13, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants