Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47889: Prevent DB connection pool exhaustion in Butler server #1124

Merged
merged 3 commits into from
Dec 5, 2024

Limit the maximum retry time for query streaming

8ea635f
Select commit
Loading
Failed to load commit list.
Merged

DM-47889: Prevent DB connection pool exhaustion in Butler server #1124

Limit the maximum retry time for query streaming
8ea635f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

89.45% (+0.00%) compared to f8303a5

View this Pull Request on Codecov

89.45% (+0.00%) compared to f8303a5

Details

Codecov Report

Attention: Patch coverage is 92.13483% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (f8303a5) to head (8ea635f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../lsst/daf/butler/remote_butler/_http_connection.py 86.66% 2 Missing and 2 partials ⚠️
tests/test_server.py 92.85% 1 Missing and 1 partial ⚠️
.../remote_butler/server/handlers/_query_streaming.py 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   89.44%   89.45%           
=======================================
  Files         366      366           
  Lines       48614    48684   +70     
  Branches     5890     5897    +7     
=======================================
+ Hits        43485    43548   +63     
- Misses       3717     3721    +4     
- Partials     1412     1415    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov