DM-47543: Reduce likelihood of collection deadlocks

[dhirving]

Fix an issue where concurrent calls to transfer_from() in Prompt Processing were causing Postgres to abort with a deadlock error.

We now register collection names in alphabetical order when multiple collections are registered inside a transaction in transfer_from(). Because ButlerCollections.register() inserts rows into a table with a unique index, Postgres takes a lock when the row is inserted and holds it until the end of the transaction. If there are two processes with concurrent transactions attempting to create the same collections, it is possible for the locks to be acquired in different orders, causing a deadlock.

Checklist

• ran Jenkins
• added a release note for user-visible changes to doc/changes
• (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.42%. Comparing base (615b2ba) to head (477fdf6).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1116   +/-   ##
=======================================
  Coverage   89.41%   89.42%           
=======================================
  Files         363      363           
  Lines       48440    48444    +4     
  Branches     5879     5879           
=======================================
+ Hits        43315    43319    +4     
  Misses       3716     3716           
  Partials     1409     1409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TallJimbo]

This is a somewhat expensive equality key, and I think the str dataset type name would work as well.