Skip to content

Commit

Permalink
Move pull earlier
Browse files Browse the repository at this point in the history
  • Loading branch information
dhirving committed Nov 15, 2023
1 parent 378d11f commit c7e3044
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,15 @@ jobs:
image: ${{ github.repository }}
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: Load docker image
# Because of limitations in Docker buildx (which underlies the build-and-push-to-ghcr action),
# we can't both push the Docker image and have it available locally in the same build action.
# So we have to go pull it from the registry before using it here.
# See https://github.com/docker/build-push-action/issues/906#issuecomment-1686036330
run: |
docker pull ghcr.io/${{ github.repository }}@${{ steps.build.outputs.imageid }}
docker images
- name: Set up Python
uses: actions/setup-python@v4
with:
Expand All @@ -70,11 +79,6 @@ jobs:
pip install -v --no-deps -e .
- name: Run smoke test
# Because of limitations in Docker buildx (which underlies the build-and-push-to-ghcr action),
# we can't both push the Docker image and have it available locally in the same build action.
# So we have to go pull it from the registry before using it here.
# See https://github.com/docker/build-push-action/issues/906#issuecomment-1686036330
run: |
docker pull ghcr.io/${{ github.repository }}@${{ steps.build.outputs.imageid }}
export BUTLER_SERVER_DOCKER_IMAGE=${{ steps.build.outputs.imageid }}
python tests_integration/test_docker_container.py

0 comments on commit c7e3044

Please sign in to comment.