Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47636: Switch CROSSTALK masking to use subtrahend masking #287

Merged
merged 1 commit into from
Dec 10, 2024
Merged

DM-47636: Switch CROSSTALK masking to use subtrahend masking #287

merged 1 commit into from
Dec 10, 2024

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Dec 4, 2024

Only exclude mask planes we've asked to exclude.

@czwa czwa requested a review from erykoff December 4, 2024 21:48
erykoff
erykoff approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't realize we were setting the andMask and using it elsewhere and not here. 🤦

@czwa czwa merged commit 21778b9 into main Dec 10, 2024
2 checks passed
@czwa czwa deleted the tickets/DM-47636 branch December 10, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czwa @erykoff