DM-47365: new manual defects for LSSTComCam #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferte
force-pushed
the
tickets/DM-47365
branch
from
6ae80b8 to
771a704
Compare
czwa
approved these changes
Dec 5, 2024
python/lsst/cp/pipe/cpDefects.py
Outdated
| @@ -1189,6 +1208,7 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs): | |||
| self.chooseBest(inputs['inputDarkDefects']), | |||
| self.chooseBest(inputs['inputBiasDefects'])] | |||
|
|
|||
| tempList.extend(inputs["inputManualDefects"]) | |||
There was a problem hiding this comment.
I think this needs a check to see if this exists. If doManualDefects=False, this connection will get dropped, so there will be no entry in inputs with this key. I don't think this needs a check on doManualDefects (although that wouldn't hurt), but checking if "inputManualDefects" in inputs.keys(): should ensure that this won't raise.
aferte
force-pushed
the
tickets/DM-47365
branch
from
771a704 to
6b2c836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.