Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45135: Update task names in cp_pipe yaml files for LSSTCam #251

Merged
merged 2 commits into from
Jul 9, 2024
Merged

DM-45135: Update task names in cp_pipe yaml files for LSSTCam #251

merged 2 commits into from
Jul 9, 2024

Conversation

jchiang87
Copy link
Contributor

No description provided.

@timj
Copy link
Member

timj commented Jul 8, 2024

Can I push a quick numpy 2 fix to this branch to fix this:

cp_pipe/python/lsst/cp/pipe/ptc/cpPtcSolve.py:971:23: NPY201 [*] `np.NINF` will be removed in NumPy 2.0. Use `-np.inf` instead.
cp_pipe/python/lsst/cp/pipe/ptc/cpPtcSolve.py:980:23: NPY201 [*] `np.NINF` will be removed in NumPy 2.0. Use `-np.inf` instead.```

?

@jchiang87 jchiang87 requested a review from czwa July 8, 2024 22:11
czwa
czwa approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this inconsistency.
Numpy fix looks good as well.

@jchiang87 jchiang87 merged commit bdebc0c into main Jul 9, 2024
2 checks passed
@jchiang87 jchiang87 deleted the tickets/DM-45135 branch July 9, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchiang87 @timj @czwa