DM-48145: restore testing for forced-astrometry failures and partial-outputs handling #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
approved these changes
Jan 8, 2025
TallJimbo
force-pushed
the
tickets/DM-48145
branch
from
eeb7b6b to
3473492
Compare
This makes one detector fail to fit astrometry (by making a treshold unrealistically small), so we can test what happens downstream. An extremely similar test was previously removed when we switched to CalibrateImageTask, since that changed how the failure looked to downstream tasks and (at the time) we hadn't yet updated them to behave correctly.
Since the string literal "id" is never equal to an integer, these tests were definitely not working as intended before.
TallJimbo
force-pushed
the
tickets/DM-48145
branch
from
3473492 to
fde205d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.