Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47636: Switch CROSSTALK masking to use subtrahend masking #48

Merged
merged 1 commit into from
Dec 10, 2024
Merged

DM-47636: Switch CROSSTALK masking to use subtrahend masking #48

merged 1 commit into from
Dec 10, 2024

Conversation

czwa
Copy link
Collaborator

@czwa czwa commented Dec 9, 2024

No description provided.

@czwa czwa requested a review from erykoff December 9, 2024 20:05
erykoff
erykoff approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only view the ptc diff on github but it looks fine. Interesting that there are these changes with fixing the mask rejection part of the code!

@czwa czwa merged commit a849b84 into main Dec 10, 2024
2 checks passed
@czwa czwa deleted the tickets/DM-47636 branch December 10, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czwa @erykoff