Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46356: Update testing to use new IsrTaskLSST calibration pipeline #41

Merged
merged 21 commits into from
Oct 31, 2024
Merged

DM-46356: Update testing to use new IsrTaskLSST calibration pipeline #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
142b9a5
Move legacy LATISS specific ci_cpp_gen3 pipelines to LATISS/legacy_20…
erykoff Sep 18, 2024
b5738f1
Move legacy LATISS tests in SConscript, to be activated with env var.
erykoff Sep 18, 2024
cef2cb7
Update legacy tests to run with CI_CPP_LEGACY env var set to 1.
erykoff Sep 18, 2024
3fb7b51
Move legacy test comparison yamls to legacy directory.
erykoff Sep 18, 2024
e8edae7
Add new IsrTaskLSST based pipelines to SConscript.
erykoff Sep 18, 2024
7dc917d
Update test code to support new IsrTaskLSST outputs.
erykoff Sep 18, 2024
bc374cc
Add local science run pipeline for IsrTaskLSST.
erykoff Sep 18, 2024
01ad6c7
Add test verification yamls for new IsrTaskLSST pipelines.
erykoff Sep 18, 2024
e3da606
Use instrument-specific directory for local pipelines.
erykoff Sep 21, 2024
14890f8
Add appropriate TODOs for full ISR pipeline.
erykoff Sep 23, 2024
13ba071
Add running of BFK generation pipeline.
erykoff Sep 23, 2024
f8a9384
Add running of gainFromFlatPairs subset.
erykoff Sep 23, 2024
fa45477
Add SpectroFlat to new ISR pipeline.
erykoff Oct 17, 2024
7cfd201
Fix reading of flat verification files.
erykoff Oct 17, 2024
bd670a6
Loosen verification requirement threshold.
erykoff Oct 22, 2024
4eb6579
Add more configurability to yaml comparisons.
erykoff Oct 23, 2024
190c81b
Loosen some tolerance parameters.
erykoff Oct 23, 2024
8f0f7a4
Make sure recursive calls to assertYamlEqual get delta override.
erykoff Oct 24, 2024
b7e7c02
Loosen tolerances for linux-aarch64.
erykoff Oct 24, 2024
8420e3c
Add building of CTI to test pipelines.
erykoff Oct 29, 2024
9786c84
Update reference ptcDet.yaml based on new statistics.
erykoff Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
983 changes: 722 additions & 261 deletions DATA/SConscript
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pipelines/cpCrosstalk.yaml → ...nes/LATISS/legacy_202409/cpCrosstalk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description: ci_cpp CROSSTALK calibration construction
instrument: lsst.obs.lsst.Latiss
imports:
- location: $CP_PIPE_DIR/pipelines/LATISS/cpCrosstalk.yaml
- location: $CP_PIPE_DIR/pipelines/LATISS/legacy_202409/cpCrosstalk.yaml
tasks:
cpCrosstalkSolve:
class: lsst.cp.pipe.CrosstalkSolveTask
Expand Down
2 changes: 1 addition & 1 deletion pipelines/cpCti.yaml → pipelines/LATISS/legacy_202409/cpCti.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description: cp_pipe CTI calibration construction -- for ci_cpp only!
instrument: lsst.obs.lsst.Latiss
imports:
- location: $CP_PIPE_DIR/pipelines/LATISS/cpCti.yaml
- location: $CP_PIPE_DIR/pipelines/LATISS/legacy_202409/cpCti.yaml
tasks:
cpCtiSolve:
class: lsst.cp.pipe.CpCtiSolveTask
Expand Down
0 pipelines/runCti.yaml → pipelines/LATISS/legacy_202409/runCti.yaml
View file
Open in desktop
File renamed without changes.
0 pipelines/runIsr.yaml → pipelines/LATISS/legacy_202409/runIsr.yaml
View file
Open in desktop
File renamed without changes.
9 changes: 9 additions & 0 deletions pipelines/LATISS/runIsrLSST.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
description: ISR run on LATISS for ci_cpp_gen3
instrument: lsst.obs.lsst.Latiss
tasks:
isr:
class: lsst.ip.isr.IsrTaskLSST
config:
overscanCamera.defaultDetectorConfig.defaultAmpConfig.saturation: 120000
# TODO DM-46426: Add cpCtiLSST pipeline so that this can be True.
doDeferredCharge: false
Loading
Loading