-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-47972: Support entry points for loading external metadata translators #80
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 87.97% 87.32% -0.66%
==========================================
Files 37 37
Lines 3144 3187 +43
Branches 414 423 +9
==========================================
+ Hits 2766 2783 +17
- Misses 260 280 +20
- Partials 118 124 +6 ☔ View full report in Codecov by Sentry. |
4822150
to
a07513a
Compare
entry_points API is different in 3.9.
Anything registered with the group astro_metadata_translators will be available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and makes the changes outlined here.
I verified using lsstsw
tools that astrometadata --list-plugins
shows the list of available translator plugins, and an update was also made by @timj to list the built-in translators as well.
I would suggest adding better test coverage for the plugin functionality in the future, possibly using a dummy/mock internal package. Or a CI repo could be created and depend on astro_metadata_translator
plus several of the other repositories that implement plugins.
Does not list plugins since there are no plugins, but does list builtins.
12a4b5e
to
ec985f2
Compare
No description provided.