DM-46970: Handle None values in table mode #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 87.99% 87.97% -0.02%
==========================================
Files 37 37
Lines 3106 3144 +38
Branches 413 414 +1
==========================================
+ Hits 2733 2766 +33
- Misses 258 260 +2
- Partials 115 118 +3 ☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-46970
branch
from
7c4c72a to
9b77edd
Compare
If a translation fails we still need to be able to display the table contents.
timj
force-pushed
the
tickets/DM-46970
branch
from
c028661 to
e9b5886
Compare
andy-slac
approved these changes
Dec 5, 2024
timj
force-pushed
the
tickets/DM-46970
branch
from
b0fd641 to
1616c8f
Compare
This requires that column data be accumulated during file reads rather than being output as each file is encountered.
Now that the output table accumulates rather than having the row printed instantly, batch up table output and dump it every few hundred entries. Without this it's possible people could be waiting a long time with no output appearing and eating up lots of memory.
timj
force-pushed
the
tickets/DM-46970
branch
from
1616c8f to
cdace0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a translation fails we still need to be able to display the table contents.