DM-43103: Add ObservationInfo.can_see_sky property #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 79.70% 88.24% +8.54%
==========================================
Files 36 37 +1
Lines 3148 3097 -51
Branches 672 658 -14
==========================================
+ Hits 2509 2733 +224
+ Misses 508 247 -261
+ Partials 131 117 -14 ☔ View full report in Codecov by Sentry. |
2 tasks
This lets click override stdout for testing, which it can't do if sys.stdout is forced to be the default.
Defaulting to sys.stderr hides it from click. Rather than trying to use click.echo replace it with a logger (which will default to using sys.stderr).
erykoff
approved these changes
Mar 28, 2024
|
I added 5% coverage so I'm going to call that a win. This has no effect on the test failure we were getting. On a previous PR I made the test more expressive in its failure output so we would know why it is failing but I don't think it's failed since I added that. |
This will stop it complaining about some lines that are never going to be hit in a test.
|
Ok. I added extra coverage and stopped it complaining about some lines that were never going to be tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.