DM-42636: Add ObservationInfo.observing_day_offset #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 78.59% 79.60% +1.00%
==========================================
Files 36 36
Lines 3140 3133 -7
Branches 670 670
==========================================
+ Hits 2468 2494 +26
+ Misses 549 508 -41
- Partials 123 131 +8 ☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-42636
branch
5 times, most recently
from
7eb96f4 to
11dc953
Compare
|
@TallJimbo this is ready for review. There are many cleanup commits that you can ignore. There is only one commit that adds |
This was referenced Feb 27, 2024
TallJimbo
approved these changes
Feb 28, 2024
This package is deprecated and does not work on python 3.12.
timj
force-pushed
the
tickets/DM-42636
branch
from
6b3be28 to
cf7fd9c
Compare
This offset is what is used to calculate an observing day from an observation date. There is also a class method allowing the offset to be calculated from the observation date. Each translator must declare an explicit value -- the default is None and is equivalent to applying 0 offset when converting a date time to an observing day.
I do not think the warning about switching to HIERARCH should exist at all. The purpose of the Header class is to transparently store the information in FITS in such a form that when we read the header we get the information back. HIERARCH is an internal implementation detail.
This also resulted in the astrometadata translate script implementation getting a new name.
Sometimes this test fails with 4 conversion failurs instead of 3 and we do not know why because there is no useful output. This change adds the output from the conversions on failure and adjusts the test to compare the okay and failed count at the same time by using a tuple.
timj
force-pushed
the
tickets/DM-42636
branch
from
cf7fd9c to
5c1496b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.