DM-47736 : Make preloaded_SsObjects optional for ssSingleFrameAssociation #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Nov 21, 2024
| @@ -109,7 +110,7 @@ def run(self, | |||
| exposure, | |||
| sourceTable, | |||
| band, | |||
| solarSystemObjectTable): | |||
| solarSystemObjectTable=None): | |||
There was a problem hiding this comment.
Please add "or None" to the docstring.
There was a problem hiding this comment.
Please add entries for exposure and sourceTable as well, on a separate commit.
| # Associate DiaSources with DiaObjects | ||
| associatedSsSources = self.associateSources(sourceTable, solarSystemObjectTable, exposure) | ||
| if solarSystemObjectTable is None: | ||
| associatedSsSources = None |
There was a problem hiding this comment.
It sounds like this still counts as a success for the purposes of pipeline tracking, so I'd rather raise NoWorkFound just to be explicit that the task did nothing.
Either way, we'll have to be careful that downstream tasks take ssSingleFrameAssociatedSources as an optional input. 😬
Gerenjie
force-pushed
the
tickets/DM-47736
branch
from
e1034fe to
2c65715
Compare
kfindeisen
reviewed
Nov 21, 2024
Comment on lines
129
to
130
| solarSystemObjectTable : `pandas.DataFrame` | ||
| Preloaded Solar System objects expected to be visible in the image. | ||
| Preloaded Solar System objects expected to be visible in the image, or None. |
There was a problem hiding this comment.
Suggested change
| solarSystemObjectTable : `pandas.DataFrame` | |
| Preloaded Solar System objects expected to be visible in the image. | |
| Preloaded Solar System objects expected to be visible in the image, or None. | |
| solarSystemObjectTable : `pandas.DataFrame` or `None` | |
| Preloaded Solar System objects expected to be visible in the image. |
Gerenjie
force-pushed
the
tickets/DM-47736
branch
from
bd4afca to
b0842d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.