DM-48582: factor out configs that are repeated for each kind of visit/source analysis #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
reviewed
Feb 5, 2025
| @@ -0,0 +1,16 @@ | |||
| # Configuration for standard instances of | |||
| # sst.analysis.tools.tasks.refCatSourceAnalysis.RefCatSourceAnalysisTask | |||
sr525
reviewed
Feb 5, 2025
| config.atools.photoDiffPsfScatterVisitPlot = TargetRefCatDeltaPsfScatterVisitPlot | ||
| config.atools.photoDiffCModelScatterVisitPlot = TargetRefCatDeltaAp09ScatterVisitPlot | ||
|
|
||
| # TODO: should there be a VisitContext set here, too? |
There was a problem hiding this comment.
The contexts are applied in each atool so probably not.
This aligns the default with what LSSTComCam and LSSTComCamSim had been doing via overrides in drp_pipe, while adding some new analysis instantiations to HSC, ImSim and other precursors. That gives us more test coverage of these configurations while letting us drop duplicative configuration blocks from drp_pipe.
TallJimbo
force-pushed
the
tickets/DM-48582
branch
from
9f28494 to
4720688
Compare
This lets us delete many duplicate configurations for this task in drp_pipe.
This lets us delete duplicate configurations for this task in drp_pipe.
In AstrometricCatalogMatchVisitTask.
TallJimbo
force-pushed
the
tickets/DM-48582
branch
from
e3f4b46 to
b9b38c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.