Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47632: Move pviMetrics into visitQualityCore for calibrateImage switch. #344

Merged
merged 1 commit into from
Jan 30, 2025
Merged

DM-47632: Move pviMetrics into visitQualityCore for calibrateImage switch. #344

merged 1 commit into from
Jan 30, 2025

Conversation

TallJimbo
Copy link
Member

No description provided.

TallJimbo
TallJimbo commented Jan 29, 2025
View reviewed changes
Copy link
Member Author

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks more complicated than it is: the content of pviMetrics was moved as a block into visitQualityCore.

erykoff
erykoff approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but how did this work before with HSC (moved to calibrateImage) and ComCam (still on Calibrate)?

@TallJimbo
Copy link
Member Author

This looks fine, but how did this work before with HSC (moved to calibrateImage) and ComCam (still on Calibrate)?

There is a corresponding commit in drp_pipe that needs to be paired with this one that swaps out which analysis pipelines are imported by the DRP pipelines.

@TallJimbo TallJimbo merged commit 14153a5 into main Jan 30, 2025
8 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-47632 branch January 30, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TallJimbo @erykoff