DM-47730: fix various incorrect NoWorkFound conditions #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmullaney
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Looks fine. I've tested _task.py with my metric histogram plotting analysis tool (which is what instigated the need for band removal from filenames where desired), and matadataAnalysis.py works as I'd expect with calexpMetrics.yaml#calexpSummary.
I've just made one query about the ValueError message, but I'm approving this (analysis tools) PR,
Thanks for this!
| def validate(self): | ||
| super().validate() | ||
| if self.raiseNoWorkFoundOnEmptyMetadata and self.raiseNoWorkFoundOnIncompleteMetadata: | ||
| raise ValueError("At most 'raiseNoWorkFound' options may be set at one time.") |
There was a problem hiding this comment.
Should this say:
"At most one 'raiseNoWorkFound' option may be set at one time"
?
I'm bothered by the fact that this makes TaskMetadataAnalysisTask assume it has a TaskMetadataAnalysisTool, but this sort of assumption seems to be intrinsic to how analysis_tools is designed, and I don't think we can fix that now.
When an analysis task does not have band in its dimensions, but one of its output connections does, this avoids predicting outputs for all bands consistent with --data-query by using config.bands instead.
TallJimbo
force-pushed
the
tickets/DM-47730
branch
from
4c09bad to
4048e95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.