DM-39778: Rework analysis tools for property maps to have one analysis task for all properties #329
Conversation
enourbakhsh
force-pushed
the
tickets/DM-39778
branch
from
7929f7d to
5b060d5
Compare
| config.properties["sky_background"].operations = ["weighted_mean"] | ||
| config.properties["sky_noise"] = PropertyMapConfig | ||
| config.properties["sky_noise"].operations = ["weighted_mean"] | ||
| from lsst.analysis.tools.atools import PerTractPropertyMapTool |
There was a problem hiding this comment.
I am really happy that all of these config options are gone.
| .replace("ddec", r"$\Delta$Dec") | ||
| ) | ||
| plotInfo["property"] = ( | ||
| fig, ((ax1, ax2), (ax3, ax4)) = plt.subplots(2, 2, figsize=(16, 16)) |
There was a problem hiding this comment.
Can we either remove the uses of plt on this ticket or make a new ticket to remove them? As discussed on the previous ticket they are very slow.
There was a problem hiding this comment.
Yes, we have a new ticket (DM-47962) to remove the uses of plt. I discussed this with @erykoff. The fix does not work with the current version of skyproj. For now, the plan is to leave the slow plt code in and address its removal in DM-47962 as soon as the new version of skyproj becomes available, likely by January.
There was a problem hiding this comment.
Eli checked and confirmed that the fix does work with the new version.
enourbakhsh
force-pushed
the
tickets/DM-39778
branch
2 times, most recently
from
e53305c to
fa13cfd
Compare
enourbakhsh
force-pushed
the
tickets/DM-39778
branch
from
fa13cfd to
fdf7429
Compare
No description provided.