Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ts_idl. #76

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Remove the ts_idl. #76

merged 3 commits into from
Feb 19, 2025

Conversation

teweitsai
Copy link
Collaborator

No description provided.

@teweitsai teweitsai force-pushed the tickets/DM-48857 branch 2 times, most recently from 11df8c5 to 6bc63c4 Compare February 11, 2025 22:33
@teweitsai teweitsai requested a review from couger01 February 13, 2025 14:46
couger01
couger01 requested changes Feb 19, 2025
View reviewed changes
Copy link

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using assert_next_sample instead of flush and next for any test comparisons.

@teweitsai teweitsai requested a review from couger01 February 19, 2025 18:13
couger01
couger01 approved these changes Feb 19, 2025
View reviewed changes
Copy link

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@teweitsai teweitsai merged commit bf811a1 into develop Feb 19, 2025
1 check passed
@teweitsai teweitsai deleted the tickets/DM-48857 branch February 19, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@couger01 couger01 couger01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teweitsai @couger01