DM-43638: Fix baseline mis-alignment for monospace inline text #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us fix teh monospace font baseline alignment issue in Safari.
Move setting the default font size to the body. This gives us slightly bigger text while respecting the user stylesheet. Also make the inline code font slightly smaller to help with baseline alignment issues for inline monospace text seen in Safari. Since the rem is now smaller, made the sizes in layout.scss use ems to be relative to the size set on the body.
This is used for monospace fonts in code blocks and inline code. The default is `ui-monospace`, which gives SF Mono on macOS.
jonathansick
changed the title
This is used by the sphinx testing fixture, but isn't a dependency of Sphinx itself, so we need to add it to our own dev dependencies.
I found that in pytest 8, running multiple builds for different test roots with the sphinx text mark reused the same import of technote, which in turn means that the metadata is not being rebuilt. This is fine for normal sphinx builds where technote's technote.sphinxconf is being imported only once, and therefore is dedicated to that single sphinx build. I think the solution is to make a new project builder for tests that runs sphinx under a subprocess so that we can inspect the output at the end.
And test with Python 3.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the baseline misalignment issue we're seeing on Safari with inline monospace text. Strategies:
codemonospace text slightly to just 1rem (body is 1.1 rem). This fixes the baseline misalignment.New CSS properties:
--tn-component-text-font-sizeis 1.1rem by default and sets the font size on the body element.--tn-component-code-font-familysets the font family for code and pre code blocks.