Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date and age fields to RSPTag #470

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Add date and age fields to RSPTag #470

merged 4 commits into from
Feb 6, 2025

Conversation

athornton
Copy link
Member

No description provided.

@athornton athornton requested a review from rra February 4, 2025 02:45
rra
rra requested changes Feb 4, 2025
View reviewed changes
controller/src/controller/models/domain/rsptag.py Outdated Show resolved Hide resolved
controller/src/controller/models/domain/rsptag.py Outdated Show resolved Hide resolved
controller/src/controller/models/domain/rsptag.py Outdated Show resolved Hide resolved
controller/src/controller/models/domain/rsptag.py Outdated Show resolved Hide resolved
controller/tests/models/domain/rsptag_test.py Outdated Show resolved Hide resolved
controller/tests/models/domain/rsptag_test.py Outdated Show resolved Hide resolved
@athornton athornton force-pushed the tickets/DM-48682-dates branch from 309dd28 to 00bc416 Compare February 4, 2025 23:18
@athornton athornton requested a review from rra February 4, 2025 23:58
rra
rra reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small stuff but the change to alias tags reminds me that we need to set the date on alias tags when resolving aliases in RSPImageTag. That can be a separate PR if you want.

changelog.d/20250203_194233_athornton_DM_48682_dates.md Outdated Show resolved Hide resolved
controller/src/controller/models/domain/rsptag.py Show resolved Hide resolved
controller/src/controller/models/domain/rsptag.py Outdated Show resolved Hide resolved
controller/src/controller/models/domain/rsptag.py Outdated Show resolved Hide resolved
controller/src/controller/models/domain/rsptag.py Outdated Show resolved Hide resolved
controller/src/controller/models/domain/rsptag.py Outdated Show resolved Hide resolved
controller/tests/models/domain/rsptag_test.py Outdated Show resolved Hide resolved
controller/tests/models/domain/rsptag_test.py Outdated Show resolved Hide resolved
controller/tests/models/domain/rsptag_test.py Outdated Show resolved Hide resolved
controller/tests/models/domain/rsptag_test.py Outdated Show resolved Hide resolved
@athornton athornton force-pushed the tickets/DM-48682-dates branch from 508ce8c to a0ec20c Compare February 5, 2025 16:59
@athornton athornton requested a review from rra February 5, 2025 17:00
rra
rra approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just one remaining comment on the test of age. Thanks for fixing the RSPImage class!

controller/tests/models/domain/rsptag_test.py Outdated Show resolved Hide resolved
@athornton athornton force-pushed the tickets/DM-48682-dates branch from 24a0f9c to 0d5f8ee Compare February 6, 2025 17:30
@athornton athornton merged commit a91b08a into main Feb 6, 2025
11 checks passed
@athornton athornton deleted the tickets/DM-48682-dates branch February 6, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rra rra rra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athornton @rra