fwv #1
Draft
fwv #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golang.org/x/sync would block trying to acquire the transfer semaphore, which could result in an http status not being returned to the client until well after the queue timeout had been exceeded.
If the client disconnects while an upload is in progress, it should be aborted.
jhoblitt
force-pushed
the
IT-5635/s3nd
branch
2 times, most recently
from
e8467b7 to
cf61a22
Compare
jhoblitt
force-pushed
the
IT-5635/s3nd
branch
from
cf61a22 to
a9b9aa0
Compare
jhoblitt
force-pushed
the
IT-5635/s3nd
branch
from
a9b9aa0 to
21dd6c1
Compare
jhoblitt
force-pushed
the
IT-5635/s3nd
branch
from
21dd6c1 to
09ee251
Compare
github.com/conduitio/bwlimit's approach to trying to time writes to the socket proved to be fairly inaccurate in terms of actual data rate and seems inferior to SO_MAX_PACING_RATE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.