DM-48282: Use daf_butler subclass for SIAv2Handler with entry point #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 82.51% 83.74% +1.22%
==========================================
Files 18 19 +1
Lines 1064 1101 +37
Branches 169 166 -3
==========================================
+ Hits 878 922 +44
+ Misses 161 157 -4
+ Partials 25 22 -3 ☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-48282
branch
from
a511bf2 to
5bbc85a
Compare
The entry point label is the relevant butler universe. This provides a way for other butler universes to substitute their own handlers. Add explicit test for get_siav2_handler
timj
force-pushed
the
tickets/DM-48282
branch
2 times, most recently
from
243960e to
91c79b1
Compare
This confuses doc string validators. * numpydoc validation is disabled for this method. * D401 has to be in a different place for ruff and pydocstyle This means RUF100 has to be removed.
timj
force-pushed
the
tickets/DM-48282
branch
from
1ca3773 to
6c616e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a way for other butler universes to substitute their own handlers.
Depends on lsst/daf_butler#1142