Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47977: Fix access_format to refer to datalink not fits #25

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

timj
Copy link
Member

@timj timj commented Dec 5, 2024

No description provided.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (8fa1c3a) to head (b57a61c).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   82.29%   82.29%           
=======================================
  Files          18       18           
  Lines        1079     1079           
  Branches      174      174           
=======================================
  Hits          888      888           
  Misses        166      166           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DP0.2 change is needed for SIAv2. I'm not sure there's any interest in the "dc2.yaml" file any more, and the "datalink.org" URLs are nonsense anyway.

@timj
Copy link
Member Author

timj commented Dec 5, 2024

Re dc2: yes, nonsense but I wanted it to be self-consistent nonsense and it didn't do any harm.

Copy link
Contributor

@stvoutsin stvoutsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

@timj timj merged commit e923387 into main Dec 5, 2024
17 checks passed
@timj timj deleted the tickets/DM-47977 branch December 5, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants