DM-47128: PyPI deployment and entry points #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 82.30% 82.29% -0.02%
==========================================
Files 16 18 +2
Lines 1074 1079 +5
Branches 276 174 -102
==========================================
+ Hits 884 888 +4
- Misses 165 166 +1
Partials 25 25 ☔ View full report in Codecov by Sentry. |
timj
commented
Oct 25, 2024
|
|
||
| - name: Upload coverage to codecov | ||
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| files: ./coverage.xml | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| check-changes: |
There was a problem hiding this comment.
@mwittgen is the plan to put this code in a reusable workflow? It looks like we only made this change in sphgeom and not all the other middleware packages.
timj
force-pushed
the
tickets/DM-47128
branch
from
1bed268 to
fc7c7fa
Compare
timj
force-pushed
the
tickets/DM-47128
branch
from
fc7c7fa to
8575456
Compare
|
The workflow should run on tag |
|
Thanks for spotting the missing tags section. |
mwittgen
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.