Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 1.7 and several debugs #1

Closed
wants to merge 5 commits into from

Conversation

atabakd
Copy link

@atabakd atabakd commented Jul 16, 2019

Thank you so much for the excellent code.
I've made several debugs and modifications, e.g.

  • removed convert as it decreases resolution, and stamping empty pdfs for empty pages to maintain correct order and avoid repeating of the last page.
  • I made the code compatible with rsync
  • I have also removed converting of epubs, because I am not sure what is the best way to do it. If you convert the epub to pdf to retain the annotations, you kind of lose all the benefits of ebooks.

Feel free to reject it if you have objections to any of these changes.

@atabakd atabakd closed this Jul 17, 2019
@atabakd
Copy link
Author

atabakd commented Jul 17, 2019

Forgot to close )

@lschwetlick
Copy link
Owner

Hey, thank you for the PR! I'll check it out as soon as I can :)

@lschwetlick
Copy link
Owner

I'm only just now getting round to looking at this. How did you get the rsync to work on your reMarkable? And wouldn't it deinstall with every update?

@atabakd
Copy link
Author

atabakd commented Aug 27, 2019

sorry, I do not know why I didn't get notifications.
You can see how I did the rsync in my clone.
However, the rm2svg is broken with 1.8 update.
But, via the web interface, I can get the correct annotated PDFs, so I guess we may not need to use the converter part of the code (which is good news).
I now only miss the backup and upload options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants