fix: Don't create a tag and launch manually

lsaudon · Jul 4, 2024 · a9b9b34 · a9b9b34
1 parent a75339f
commit a9b9b34
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/.github/workflows/example_cd.yaml b/.github/workflows/example_cd.yaml
@@ -1,17 +1,14 @@
 name: continuous-delivery
 
 on:
-  push:
-    tags:
-      - 'v*'
+  workflow_dispatch
 
 env:
   FLUTTER_VERSION: 3.22.2
 
 jobs:
   continuous-delivery-ios:
     runs-on: macos-latest
-    if: github.ref == 'refs/heads/main'
     defaults:
       run:
         working-directory: example/ios

diff --git a/lib/src/commands/release/version_control/version_control_git_adapter.dart b/lib/src/commands/release/version_control/version_control_git_adapter.dart
@@ -44,7 +44,6 @@ class VersionControlGitAdapter implements VersionControlPort {
     await _processManager.run(['git', 'checkout', '-b', branchName]);
     await _processManager.run(['git', 'add', 'pubspec.yaml', 'CHANGELOG.md']);
     await _processManager.run(['git', 'commit', '-m', 'chore: $versionTag']);
-    await _processManager.run(['git', 'tag', versionTag]);
     await _processManager
         .run(['git', 'push', '--atomic', 'origin', branchName, versionTag]);
   }

diff --git a/test/src/commands/release_command_test.dart b/test/src/commands/release_command_test.dart
@@ -201,8 +201,6 @@ void main() {
       when(
         () => processManager.run(['git', 'commit', '-m', 'chore: $versionTag']),
       ).thenAnswer((final _) async => ProcessResult(0, 0, '', ''));
-      when(() => processManager.run(['git', 'tag', versionTag]))
-          .thenAnswer((final _) async => ProcessResult(0, 0, '', ''));
       when(
         () => processManager.run(
           ['git', 'push', '--atomic', 'origin', versionBranch, versionTag],
@@ -245,7 +243,6 @@ void main() {
         ['git', 'checkout', '-b', versionBranch],
         ['git', 'add', 'pubspec.yaml', 'CHANGELOG.md'],
         ['git', 'commit', '-m', 'chore: $versionTag'],
-        ['git', 'tag', versionTag],
         ['git', 'push', '--atomic', 'origin', versionBranch, versionTag],
       ]) {
         verify(() => processManager.run(c));