Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions
I adapted Vasilis's code for a feature permutation test, merging it into the
permutation_test.py
script and adding it to our pipeline.By default, we now perform the following permutation tests:
Testing
I tested the updated implementation in two ways.
First, I verified that the right features were indeed being permuted, given a particular feature "class."
Second, I ran the entire pipeline with N=100 permutations, but only setting tolerance to 1E-5 and max iterations to 10000 (see the new
configs/test.yml
file). See the results below, which look reasonable to me. (Also note that these are just the TSV tables that our pipeline now outputs by default.)Model summary
Permutation test summary
Review
@lmackey: note that I am assigning you to be the sole reviewer since Vasilis has not yet joined this GitHub repo.