[dv, aon_timer] Waiving RTL unreachable statements pending rtl change #26165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antmarzam
requested review from
marnovandermaas and
rswarbrick
and removed request for
a team
antmarzam
force-pushed
the
aon_timer_temporary_rtl_exclusions
branch
from
7cf94f9 to
efeaf2e
Compare
These exclusions cover the missing branch/line coverage for aon_timer. Once are PRs lowRISC#25812/lowRISC#26072 make it to maste these exclusions can be ammendeed/removed. There's also a github issue lowRISC#26164 to re-evaluate the RTL changes which may affect CDC sign-off. Signed-off-by: Antonio Martinez Zambrana <[email protected]>
antmarzam
force-pushed
the
aon_timer_temporary_rtl_exclusions
branch
from
efeaf2e to
857de0c
Compare
rswarbrick
reviewed
Feb 11, 2025
| Branch 4 "3547459906" "gen_wr_req.state_q" (6) "gen_wr_req.state_q default,-,-,-,-" | ||
| CHECKSUM: "1125143680 279071062" | ||
| INSTANCE: tb.dut.u_reg.u_wkup_count_hi_cdc | ||
| ANNOTATION: "Src_ack will only be set after src_busy_q is set. This can be removed via RTL modification, and it will be revisit after the next CDC sign-off. Issue is #26164" |
There was a problem hiding this comment.
Grammar nit: "Revisited"
| //================================================== | ||
| CHECKSUM: "2180545894 2543311903" | ||
| INSTANCE: tb.dut.u_reg.u_wkup_count_hi_cdc.u_arb | ||
| ANNOTATION: "Default statement can't be hit. PR#26072 takes care of ammending RTL. In the meantime excluded to close coverage." |
There was a problem hiding this comment.
It might make sense to drop the PR number here. Otherwise, we end up with a "dead link" if we close that PR and open a different one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These exclusions cover the missing branch/line coverage for aon_timer. Once are PRs #25812/#26072 make it to maste these exclusions can be ammendeed/removed.
There's also a github issue #26164 to re-evaluate the RTL changes which may affect CDC sign-off.