[hmac] Remove read signal and disable assert for TLUL FIFO adapter #26163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- msg_fifo_rvalid signal is useless as it cannot be 1 as the memory is a Write Only memory. Signed-off-by: Martin Velay <[email protected]>
martin-velay
added
IP:hmac
Component:DV
martin-velay
force-pushed
the
read_assert
branch
from
453f3d7 to
d33f07c
Compare
martin-velay
force-pushed
the
read_assert
branch
from
d33f07c to
6bc54ab
Compare
- Exclude the assertions related to the read part as this particular FIFO instance is WO, to avoid to have uncovered assertions. Signed-off-by: Martin Velay <[email protected]>
martin-velay
force-pushed
the
read_assert
branch
from
6bc54ab to
3f02a04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four assertions are not covered for the HMAC:
That's because this FIFO is WO. The proposed solution is to remove the useless
msg_fifo_rvalidsignal from the RTL and to exclude the assertions.