[tlul,rtl] Drop unused typedef from tlul_adapter_sram #26003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seemed sensible when I originally ported the code to use the shared fifo, but it turns out not to be needed. And Pirmin (quite reasonably) pointed out that the name is rather confusing. Forget about it! Signed-off-by: Rupert Swarbrick <[email protected]>
nasahlpa
approved these changes
Jan 24, 2025
|
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_adapter_sram.sv This PR merges only removes an unused typedef. |
|
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_adapter_sram.sv No functional change (this just removes an unused typedef) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed sensible when I originally ported the code to use the shared fifo, but it turns out not to be needed. And Pirmin (quite reasonably) pointed out that the name is rather confusing. Forget about it!
(I mis-clicked when merging #25951. This PR tidies up again...)