[opentitantool] Erase header of other slot during rescue #25995
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I have seen cases where the slot not being flashed during rescue still booted afterwards, meaning that the previous code flashing a zero-length image to the other slot may be ineffective. This PR changes the default behavior to flashing an 4kB image consisting entirely of 0xFF to the other slot, in order to make sure that the header of any previous image is overwritten and invalidated.