[RACL] Instantiate RACL for Darjeeling #25986
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
requested review from
eshapira and
jadephilipoom
and removed request for
a team
vogelpi
reviewed
Jan 23, 2025
Comment on lines
+5
to
+11
| role_bit_lsb: 5 | ||
| role_bit_msb: 8 | ||
| roles: { | ||
| "ROT" : { role_id: 0 } | ||
| "Role1": { role_id: 1 } | ||
| "SOC": { role_id: 2 } | ||
| } |
There was a problem hiding this comment.
I guess you will add more roles later such that the 4 role bits we have are really utilized, right?
There was a problem hiding this comment.
Yes, for the upstream we need to agree on a default set. It's not necessary to define all. The integrator defines its own custom roles and policies though.
| @@ -80,12 +80,19 @@ | |||
| reset: "rst_mbx_ni", | |||
| pipeline: false, | |||
| }, | |||
| { name: "racl_ctrl", | |||
There was a problem hiding this comment.
Question: do we add RACL to the mailbox xbar because this is the only one accessible from the outside?
There was a problem hiding this comment.
We add racl_ctrl to the CTN facing port for the following reason:
- In a multi-chiplet design, it allows the primary ROT access and configure the secondary's ROT policy registers.
The same is true for the AC Ranges. After both instanciations are merged, I will rename the mbx crossbar to CTN crossbar.
Razer6
force-pushed
the
instantiate-racl
branch
4 times, most recently
from
2f75f04 to
70e56b3
Compare
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
instantiate-racl
branch
from
70e56b3 to
5953bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initially instantiates RACL for Darjeeling by:
Note 1: This PR is based on #25749 and needs to be rebased after that one is merged.
Note 2: This PR currently has one issue, the RACL error and error log would need to be rendered as an array and not as a single element.