Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rom_ctrl, dv] Exclusion of a case where sramreqfifo_wready is false #25962

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[rom_ctrl, dv] Exclusion of a case where sramreqfifo_wready is false #25962

merged 1 commit into from
Jan 23, 2025

Conversation

KinzaQamar
Copy link
Contributor

@KinzaQamar KinzaQamar commented Jan 21, 2025 •
edited
Loading

Merge this PR first as a dependency of 25869

@KinzaQamar KinzaQamar requested a review from a team as a code owner January 21, 2025 17:58
@KinzaQamar KinzaQamar requested review from eshapira and rswarbrick and removed request for a team and eshapira January 21, 2025 17:58
@KinzaQamar KinzaQamar mentioned this pull request Jan 21, 2025
Open
@KinzaQamar KinzaQamar force-pushed the dev branch 2 times, most recently from e0c08c5 to cdd9509 Compare January 22, 2025 09:51
rswarbrick
rswarbrick approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this carefully. I agree :-)

@rswarbrick rswarbrick merged commit fc4dd19 into lowRISC:master Jan 23, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KinzaQamar @rswarbrick