[topgen] Properly uniquify the incoming alert names #25960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
requested review from
rswarbrick and
vogelpi
and removed request for
msfschaffner
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
incoming-alert-fixes
branch
from
c146012 to
bf8730d
Compare
|
Should you run topgen and include the new generated files as part of this PR? |
sameo
approved these changes
Jan 21, 2025
As discussed offline, this code path is only hit when defining external alerts. Thus in upstream, there is no diff in the generated code. |
vogelpi
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we would end up in conflicts when adding incoming alerts from other domains, which have the same module and alert name.