[dv] Make it an error to run an intr_test sequence when there are no interrupts #25959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block doesn't actually have any interrupts! I will follow this change with a commit that makes it an error to run the interrupt test sequence if there aren't any interrupts, but wanted to check this wouldn't break any blocks. To do so, I ran: ``` for x in $(git grep tests/intr_test '*.hjson' | cut -d : -f 1); do h=$(echo $x | sed 's/dv/data/' | sed 's/uvm\///' | sed 's/_sim_cfg//'); grep interrupt_list $h >/dev/null || echo $x; done ``` This doesn't quite work because of the parameterised versions of `kmac`, `spi_device` and `flash_ctrl`. But a manual check of those three blocks' hjson files shows that each has interrupts. The only block that *does* get printed is `clkmgr`, which *doesn't* have any interrupts! This commit removes the item from clmkgr_sim_cfg.hjson. Signed-off-by: Rupert Swarbrick <[email protected]>
I found this because the rom_ctrl testing was occasionally running a very short sequence! It turns out that run_intr_test_vseq exited quickly if there weren't actually any interrupt registers. Rather than claiming we're doing something, let's just stop with a failure. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
requested review from
marnovandermaas
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit tidies up the
clkmgrhjson so that it doesn't ask us to do so (and the commit message explains what's going on). The second adds the error.The second commit was originally part of #25864 but @alees24 (quite rightly!) thought it was worth checking it wouldn't break anything. It would have done, hence the first commit...