Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dv,mem_bkdr_util] Temporarily fix otp_ctrl mem_bkdr functions #25922

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

matutem
Copy link
Contributor

@matutem matutem commented Jan 17, 2025

Put back the fix in otp_ctrl_mem_bkdr_util_pkg tadded in #25884.

otp_ctrl_mem_bkdr_util_pkg needs to be a template since it depends on the partitions. Until that is done this fix will do.

@matutem matutem requested a review from a team as a code owner January 17, 2025 11:55
@matutem matutem requested review from rswarbrick and vogelpi and removed request for a team January 17, 2025 11:55
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @matutem !

Put back the fix in otp_ctrl_mem_bkdr_util_pkg tadded in lowRISC#25884.

otp_ctrl_mem_bkdr_util_pkg needs to be a template since it
depends on the partitions. Until that is done this fix will do.

Signed-off-by: Guillermo Maturana <[email protected]>
@vogelpi
Copy link
Contributor

vogelpi commented Jan 17, 2025

I ran make -k -C hw top_and_cmdgen to regenerate auto-generated sources. Now the lint checks should pass.

@matutem matutem merged commit f03d2bf into lowRISC:master Jan 17, 2025
38 checks passed
@matutem matutem deleted the otp_mem_bkdr_util branch January 17, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants