[hw,ac_range_check,rtl] Add RACL checks to the AC Range Checks #25906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
requested review from
andreaskurth,
rswarbrick and
vogelpi
and removed request for
msfschaffner
rswarbrick
reviewed
Jan 17, 2025
Razer6
force-pushed
the
ac-range-check-racl
branch
from
a018a82 to
c56e188
Compare
|
@rswarbrick Thanks for looking into this. I fixed the nit and made the bit calculation more readable. Can you take another look? |
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
ac-range-check-racl
branch
from
c56e188 to
8b72ccf
Compare
Thanks for look into this. I just rebased this PR on top of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RACL checks to the AC ranges. Now that RACL is (partly) merged, we can enable the RACL checks first.
RACL error logging is not yet fully implemented as it depends on determining the failing range.