[hw,pwrmgr,rtl] Make the SoC see what the slow FSM sees #25889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelpi
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
LGTM, thanks @Razer6 .
The CI failure is related to the OTP issue for which @rswarbrick did a hot fix. Can you please rebase?
| } | ||
| ); | ||
| // Make the SoC see what the slow FSM sees to to generate the light_reset to the SoC | ||
| assign internal_reset_req = |slow_peri_reqs_masked.rstreqs; |
There was a problem hiding this comment.
This looks good to me. For other reviewers slow_per_reqs_masked.rstreqs is defined as follows:
assign slow_peri_reqs_masked.rstreqs = slow_peri_reqs.rstreqs &
{{NumSwRstReq{1'b1}},
{NumDebugRstReqs{1'b1}},
{NumIntRstReqs{1'b1}},
slow_reset_en};So this change here effectively allows forwarding the reset enabled with reg2hw.reset_en[1].
There was a problem hiding this comment.
Thanks for the explanation: that makes sense to me now!
... to generate the light reset request. Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
pwrmgr-soc-reset
branch
from
3b1e2c5 to
e3038fc
Compare
@vogelpi Just rebased to the latest changes in master. |
rswarbrick
approved these changes
Jan 18, 2025
| } | ||
| ); | ||
| // Make the SoC see what the slow FSM sees to to generate the light_reset to the SoC | ||
| assign internal_reset_req = |slow_peri_reqs_masked.rstreqs; |
There was a problem hiding this comment.
Thanks for the explanation: that makes sense to me now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to generate the light reset request.