Cherry-pick to master: [rom_ext] Ownership transfer manual cherry-picks from earlgrey_es_sival #25888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moidx
approved these changes
Jan 16, 2025
cfrantz
force-pushed
the
master-port-24939
branch
2 times, most recently
from
e95e890 to
7fabbb1
Compare
Test the configuration options of the rescue protocol. The `transfer_lib` is enhanced to allow for pre-set variations of the ownership config through the `OwnerConfigKind` enum. The rust-based test harnesses are near-clones of the `transfer_test` harness, however, they allow for certain expected errors during the transfer process (such as a `Cancel` during the rescue upload) and test for specific conditions after owner activation. `rescue_limit_test`: Fixes lowRISC#24474. `rescue_permission_test`: Fixes lowRISC#24475. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit f94ca18) (cherry picked from commit 8ddcef5)
Initially we were considering the SPI bootstrap mechanism as the ROM_EXT rescue mechanism, however, we ended up going a different direction. 1. Remove the ROM_EXT SPI bootstrap code. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit bff38c1) (cherry picked from commit 12c6a84)
1. Add the capability to perform lockdown of the MP region configuration
via the REGION_CFG_REGWEN registers.
2. In `owner_block_flash_apply`, apply the PROTECT_WHEN_PRIMARY and LOCK
properties only when lockdown is requested.
3. In the `{un,}locked_init` functions, do not perform lockdown:
- We do not want regions locked for the `LockedOwner` state should
the user request rescue mode.
- We do not want regions locked in the ownership unlocked states.
4. Prior to execution handoff to owner code, engage the owner-configured
locks.
Signed-off-by: Chris Frantz <[email protected]>
(cherry picked from commit de7df51)
(cherry picked from commit d3248be)
`flash_permission_test`: Fixes: lowRISC#24476 Adds a test harness that verifies the flash configuration state of data regions. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 890e5bf) (cherry picked from commit 173c8a2)
cfrantz
force-pushed
the
master-port-24939
branch
from
7fabbb1 to
e94883c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains manual cherry-picks for commits included in the following PRs:
These changes are being merged into
master.