-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Check lock files in CI #25832
[ci] Check lock files in CI #25832
Conversation
Stupid question: with this check, does that mean that in certain cases, if a new version of package is available, the check will fail because cargo/pip/bazel will resolve to a different version? Here I am thinking about requirements that only specify a major.minor version for example and a new patch appears upstream. |
The cargo update command has Pip is already checked in ci/scripts/check-generated.sh, so it should be moved/removed from this PR, and we know that it won't be affected by upstream package upgrade. Not sure about Bazel deps though. |
Yes, I added Both of them come back as up to date and it seems likely there have been new versions since the last time they were changed, so maybe we can assume that they're okay? |
This script regenerates the Bazel, Cargo, and Python lock files and checks for a diff. Signed-off-by: James Wainwright <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. Let's merge and we'll see how this check behaves. If we notice some issues with python or bazel, we can always do a partial revert.
This script regenerates the Bazel, Cargo, and Python lock files and checks for a diff.