Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch URL error if remote stats bucket does not exist #25829

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Jan 9, 2025

When creating a new IP or moving an IP to ipgen, there is no initial regression run. Consequently, fetching its stats fails as the remote path does not exist.

To unblock this error, this PR catches the URL error if the path does not exist and returns that 0 runs out of 0 are performed.

When creating a new IP or moving an IP to ipgen, there is no initial
regression run. Consequently, fetching its stats fails as the remote
path does not exist.

To unblock this error, this PR catches the URL error if the path does
not exist and returns that 0 runs out of 0 are performed.

Signed-off-by: Robert Schilling <[email protected]>
@Razer6 Razer6 requested review from jwnrt and HU90m and removed request for jwnrt January 9, 2025 10:22
Copy link
Contributor

@jwnrt jwnrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to handle this, thanks

@jwnrt
Copy link
Contributor

jwnrt commented Jan 9, 2025

FPGA failures unrelated

@jwnrt jwnrt merged commit aac71e4 into lowRISC:master Jan 9, 2025
36 of 38 checks passed
@Razer6 Razer6 deleted the catch-stats-error branch January 9, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants