[dd, prim] Simplyfing condition to ease coverage closure #25814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
reviewed
Jan 8, 2025
rswarbrick
reviewed
Jan 23, 2025
The acknoledgement can't be set unless the request is set. The condition has been simplified to only check for the acknoledgment. In addition, the new assertion checks if the ack is set, the request must be set Signed-off-by: Antonio Martinez Zambrana <[email protected]>
antmarzam
force-pushed
the
prim_reg_cdc_arb_cond_cov_simplification
branch
from
dbdb415 to
a7defe5
Compare
rswarbrick
approved these changes
Jan 30, 2025
|
CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_reg_cdc_arb.sv No functional change (by careful reasoning and an assertion that gets added). This should give no risk to earlgrey. |
|
As a note: If #25705 gets merged before this PR, we'll need to update the exclusion file to drop the exclusions that this RTL change gets rid of. |
alees24
approved these changes
Jan 31, 2025
|
CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_reg_cdc_arb.sv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acknoledgement can't be set unless the request is set. The condition has been simplified to only check for the acknoledgment.
In addition, the new assertion checks if the ack is set, the request must be set